Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbbGaClY (ORCPT ); Thu, 30 Jul 2015 22:41:24 -0400 Received: from mailgw02.mediatek.com ([218.249.47.111]:57729 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750977AbbGaClW (ORCPT ); Thu, 30 Jul 2015 22:41:22 -0400 X-Listener-Flag: 11101 Message-ID: <1438310471.24722.4.camel@mhfsdcap03> Subject: Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus From: leilk liu To: Jonas Gorski CC: Mark Brown , Mark Rutland , Matthias Brugger , Sascha Hauer , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , , Date: Fri, 31 Jul 2015 10:41:11 +0800 In-Reply-To: References: <1438167874-1305-1-git-send-email-leilk.liu@mediatek.com> <1438167874-1305-2-git-send-email-leilk.liu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2460 Lines: 80 Hi Jonas, On Thu, 2015-07-30 at 21:27 +0200, Jonas Gorski wrote: > Hi, > > On Wed, Jul 29, 2015 at 1:04 PM, Leilk Liu wrote: > > Signed-off-by: Leilk Liu > > --- > > .../devicetree/bindings/spi/spi-mt65xx.txt | 38 ++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > new file mode 100644 > > index 0000000..f8005d6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > > @@ -0,0 +1,38 @@ > > +MTK SPI device > > You are calling it "MediaTek SPI controller" in the Kconfig entry, so > you should call it that here as well. > OK, I will fix it. > > + > > +Required properties: > > +- compatible: should be one of the following. > > + - mediatek,mt8173-spi: for mt8173 platforms > > + - mediatek,mt8135-spi: for mt8135 platforms > > + - mediatek,mt6589-spi: for mt6589 platforms > > + > > +- #address-cells: should be 1. > > + > > +- #size-cells: should be 0. > > + > > +- reg: Address and length of the register set for the device > > + > > +- interrupts: Should contain spi interrupt > > + > > +- clocks: phandles to input clocks. > > + > > +- clock-names: tuple listing input clock names. > > + Required elements: "main" > > + > > +- pad-select: should specify spi pad used, only required for MT8173. > > + This value should be 0~3. > > As already commented on the v3, this is a vendor property, and must > have a vendor prefix, so it must be called "mediatek,pad-select". > OK, I will fix it on the next version. > > + > > +Example: > > + > > +- SoC Specific Portion: > > +spi: spi@1100a000 { > > + compatible = "mediatek,mt8173-spi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0 0x1100a000 0 0x1000>; > > + interrupts = ; > > + clocks = <&pericfg CLK_PERI_SPI0>; > > + clock-names = "main"; > > + pad-select = <0>; > > + status = "disabled"; > > +}; > > > Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/