Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751023AbbGaENf (ORCPT ); Fri, 31 Jul 2015 00:13:35 -0400 Received: from ozlabs.org ([103.22.144.67]:37965 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbbGaENe (ORCPT ); Fri, 31 Jul 2015 00:13:34 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 120d200a86273d1840d091959dca65617cd9eff2 In-Reply-To: <1437139231-11812-1-git-send-email-luis.henriques@canonical.com> To: Luis Henriques , Benjamin Herrenschmidt From: Michael Ellerman Cc: Paul Gortmaker , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: macintosh/ans-lcd: fix build failure after module_init/exit relocation Message-Id: <20150731041332.09F9014031E@ozlabs.org> Date: Fri, 31 Jul 2015 14:13:31 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1837 Lines: 37 On Fri, 2015-17-07 at 13:20:31 UTC, Luis Henriques wrote: > After commit 0fd972a7d91d ("module: relocate module_init from init.h to module.h") > ans-lcd module fails to build with: > > drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class [enabled by default] > module_init(anslcd_init); > ^ > drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] > drivers/macintosh/ans-lcd.c:201:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/macintosh/ans-lcd.c:202:1: warning: data definition has no type or storage class [enabled by default] > module_exit(anslcd_exit); > ^ > drivers/macintosh/ans-lcd.c:202:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int] > drivers/macintosh/ans-lcd.c:202:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/macintosh/ans-lcd.c:155:1: warning: 'anslcd_init' defined but not used [-Wunused-function] > anslcd_init(void) > ^ > drivers/macintosh/ans-lcd.c:195:1: warning: 'anslcd_exit' defined but not used [-Wunused-function] > anslcd_exit(void) > ^ > > This commit fixes it by replacing linux/init.h by linux/module.h. > > Fixes: 0fd972a7d91d ("module: relocate module_init from init.h to module.h") > Signed-off-by: Luis Henriques > Acked-by: Paul Gortmaker Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/120d200a86273d1840d0 cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/