Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbbGaGrD (ORCPT ); Fri, 31 Jul 2015 02:47:03 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:37375 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbGaGrA (ORCPT ); Fri, 31 Jul 2015 02:47:00 -0400 Message-ID: <1438325218.16598.16.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] target: improve unsupported opcode message From: "Nicholas A. Bellinger" To: Spencer Baugh Cc: "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" , open list , Joern Engel , Spencer Baugh Date: Thu, 30 Jul 2015 23:46:58 -0700 In-Reply-To: <1437602500-3793-1-git-send-email-sbaugh@catern.com> References: <1437602500-3793-1-git-send-email-sbaugh@catern.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2080 Lines: 56 On Wed, 2015-07-22 at 15:01 -0700, Spencer Baugh wrote: > From: Joern Engel > > Make the warning about unsupported SCSI opcode more useful: > > - Add in the initiator name so we know who's sending it. > - Print the warning even for opcodes that spc_parse_cdb() knows about > but that we don't handle. > > Signed-off-by: Joern Engel > Signed-off-by: Spencer Baugh > --- > drivers/target/target_core_spc.c | 3 --- > drivers/target/target_core_transport.c | 5 +++++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/target/target_core_spc.c b/drivers/target/target_core_spc.c > index b074443..87d4adb 100644 > --- a/drivers/target/target_core_spc.c > +++ b/drivers/target/target_core_spc.c > @@ -1405,9 +1405,6 @@ spc_parse_cdb(struct se_cmd *cmd, unsigned int *size) > } > break; > default: > - pr_warn("TARGET_CORE[%s]: Unsupported SCSI Opcode" > - " 0x%02x, sending CHECK_CONDITION.\n", > - cmd->se_tfo->get_fabric_name(), cdb[0]); > return TCM_UNSUPPORTED_SCSI_OPCODE; > } > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > index ce8574b..ac002a7 100644 > --- a/drivers/target/target_core_transport.c > +++ b/drivers/target/target_core_transport.c > @@ -1246,6 +1246,11 @@ target_setup_cmd_from_cdb(struct se_cmd *cmd, unsigned char *cdb) > } > > ret = dev->transport->parse_cdb(cmd); > + if (ret == TCM_UNSUPPORTED_SCSI_OPCODE) > + pr_warn_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n", > + cmd->se_tfo->get_fabric_name(), > + cmd->se_sess->se_node_acl->initiatorname, > + cmd->t_task_cdb[0]); > if (ret) > return ret; > Applied to target-pending/for-next. Thanks Joern + Spencer! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/