Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbbGaHWM (ORCPT ); Fri, 31 Jul 2015 03:22:12 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44487 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbbGaHWK (ORCPT ); Fri, 31 Jul 2015 03:22:10 -0400 Date: Fri, 31 Jul 2015 00:22:04 -0700 (PDT) Message-Id: <20150731.002204.2044640569422262574.davem@davemloft.net> To: nathan.sullivan@ni.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume From: David Miller In-Reply-To: <20150730230905.GA9355@nathan3500-linux-VM> References: <1438269348-8725-1-git-send-email-nathan.sullivan@ni.com> <20150730.100034.1983500409184401997.davem@davemloft.net> <20150730230905.GA9355@nathan3500-linux-VM> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 31 Jul 2015 00:22:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 26 From: Nathan Sullivan Date: Thu, 30 Jul 2015 18:09:05 -0500 > On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: >> From: Nathan Sullivan >> Date: Thu, 30 Jul 2015 10:15:48 -0500 >> >> > Changes for V2: Actually make sure it compiles this time. >> >> If V1 didn't compile, even for you, then I have a big problem. >> >> And that problem is that you didn't test this change at all. > > Sorry about that, I have tested it against 3.14, which is why I had > the older interrupt function in v1. On HEAD, the phy no longer > suspends when ethernet goes down on our hardware - I'm still working > on figuring out why. I'm also surprised no one noticed this behavior > before I did, but if the phy never goes into suspend you wouldn't. I think you should sort out the PHY suspending issue before we move forward with this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/