Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbbGaI56 (ORCPT ); Fri, 31 Jul 2015 04:57:58 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36645 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbbGaI5z (ORCPT ); Fri, 31 Jul 2015 04:57:55 -0400 Date: Fri, 31 Jul 2015 10:57:50 +0200 From: Ingo Molnar To: Brian Gerst Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Denys Vlasenko , Andy Lutomirski , Linus Torvalds Subject: Re: [PATCH 5/8] x86/vm86: Add a separate config option for hardware IRQ handling Message-ID: <20150731085750.GA8289@gmail.com> References: <1438148483-11932-1-git-send-email-brgerst@gmail.com> <1438148483-11932-6-git-send-email-brgerst@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438148483-11932-6-git-send-email-brgerst@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 41 * Brian Gerst wrote: > Allow disabling hardware interrupt support for vm86. > > Signed-off-by: Brian Gerst > --- > arch/x86/Kconfig | 8 ++++++++ > arch/x86/include/asm/irq_vectors.h | 10 ---------- > arch/x86/include/asm/vm86.h | 20 ++++++++++++++++++-- > arch/x86/kernel/vm86_32.c | 12 ++++++++++-- > 4 files changed, 36 insertions(+), 14 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index cbd2d62..7c7ec31 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1067,6 +1067,14 @@ config VM86 > bool > default X86_LEGACY_VM86 > > +config VM86_INTERRUPTS > + bool "Enable VM86 interrupt support" > + default y > + depends on VM86 > + ---help--- > + This option allows VM86 programs to request interrupts for > + real mode hardware drivers. So I'm wondering what the justification for this is. People can disable vm86 already via CONFIG_X86_LEGACY_VM86. The extra config just uglifies the code unnecessarily. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/