Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbbGaJM2 (ORCPT ); Fri, 31 Jul 2015 05:12:28 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:36725 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbGaJMY (ORCPT ); Fri, 31 Jul 2015 05:12:24 -0400 MIME-Version: 1.0 In-Reply-To: <20150731071358.GA25228@gondor.apana.org.au> References: <1438258268-3099-1-git-send-email-rsahu@apm.com> <1438258268-3099-4-git-send-email-rsahu@apm.com> <20150731071358.GA25228@gondor.apana.org.au> Date: Fri, 31 Jul 2015 14:42:23 +0530 Message-ID: Subject: Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver From: Rameshwar Sahu To: Herbert Xu Cc: Vinod Koul , dan.j.williams@intel.com, davem@davemloft.net, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 35 On Fri, Jul 31, 2015 at 12:43 PM, Herbert Xu wrote: > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: >> >> + .cra_name = "xgene(crc32c)", >> + .cra_driver_name = "crc32c-xgene", > > This looks wrong. If you're implementing crc32c then cra_name > should be just crc32c, i.e., the name of the algorithm that you > are providing. Okay, I will change it to crc32c only. > >> +MODULE_DESCRIPTION("APM X-Gene SoC CRC32C HW accelerator driver"); >> +MODULE_AUTHOR("Rameshwar Prasad Sahu "); >> +MODULE_LICENSE("GPL"); >> +MODULE_VERSION("1.0"); > > You should add a MODULE_ALIAS_CRYPTO too. Okay > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/