Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751686AbbGaJMe (ORCPT ); Fri, 31 Jul 2015 05:12:34 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36336 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbGaJMb (ORCPT ); Fri, 31 Jul 2015 05:12:31 -0400 Date: Fri, 31 Jul 2015 11:12:26 +0200 From: Ingo Molnar To: Brian Gerst Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Denys Vlasenko , Andy Lutomirski , Linus Torvalds Subject: Re: [PATCH 4/8] x86/vm86: Use the normal pt_regs area for vm86 Message-ID: <20150731091226.GA21116@gmail.com> References: <1438148483-11932-1-git-send-email-brgerst@gmail.com> <1438148483-11932-5-git-send-email-brgerst@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438148483-11932-5-git-send-email-brgerst@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 28 * Brian Gerst wrote: > --- a/arch/x86/include/asm/vm86.h > +++ b/arch/x86/include/asm/vm86.h > +static inline void save_v86_state(struct kernel_vm86_regs *, int) { } > + So this is not a valid inline function and the patches were clearly not built with !VM86 such as 64-bit defconfig: In file included from arch/x86/kernel/signal.c:34:0: ./arch/x86/include/asm/vm86.h: In function ‘save_v86_state’: ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted static inline void save_v86_state(struct kernel_vm86_regs *, int) { } ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted I fixed this up. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/