Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751659AbbGaJe4 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 Jul 2015 05:34:56 -0400
Received: from mail-pd0-f171.google.com ([209.85.192.171]:33381 "EHLO
	mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750995AbbGaJey (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 Jul 2015 05:34:54 -0400
Date: Fri, 31 Jul 2015 15:04:50 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: yalin wang <yalin.wang2010@gmail.com>, Joe Perches <joe@perches.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
        Andrew Morton <akpm@linux-foundation.org>,
        linaro-kernel@lists.linaro.org,
        open list <linux-kernel@vger.kernel.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        David Rientjes <rientjes@google.com>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
        Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
        Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 14/15] mm: Drop unlikely before IS_ERR(_OR_NULL)
Message-ID: <20150731093450.GA7505@linux>
References: <cover.1438331416.git.viresh.kumar@linaro.org>
 <91586af267deb26b905fba61a9f1f665a204a4e3.1438331416.git.viresh.kumar@linaro.org>
 <20150731085646.GA31544@node.dhcp.inet.fi>
 <FA3D9AE9-9D1E-4232-87DE-42F21B408B24@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FA3D9AE9-9D1E-4232-87DE-42F21B408B24@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1254
Lines: 33

On 31-07-15, 17:32, yalin wang wrote:
> 
> > On Jul 31, 2015, at 16:56, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> > 
> > On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
> >> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> >> is no need to do that again from its callers. Drop it.
> >> 
> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

> search in code, there are lots of using like this , does need add this check into checkpatch ?

cc'd Joe for that. :)

> # grep -r 'likely.*IS_ERR'  .
> ./include/linux/blk-cgroup.h:	if (unlikely(IS_ERR(blkg)))
> ./fs/nfs/objlayout/objio_osd.c:	if (unlikely(IS_ERR(od))) {
> ./fs/cifs/readdir.c:	if (unlikely(IS_ERR(dentry)))
> ./fs/ext4/extents.c:		if (unlikely(IS_ERR(bh))) {
> ./fs/ext4/extents.c:		if (unlikely(IS_ERR(path1))) {
> ./fs/ext4/extents.c:		if (unlikely(IS_ERR(path2))) {

Btw, my series has fixed all of them :)

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/