Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752520AbbGaJlo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 Jul 2015 05:41:44 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:50809 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752316AbbGaJlM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 Jul 2015 05:41:12 -0400
X-IronPort-AV: E=Sophos;i="5.15,583,1432598400"; 
   d="scan'208";a="289726234"
Message-ID: <55BB42B3.1040103@citrix.com>
Date: Fri, 31 Jul 2015 10:41:07 +0100
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "Borislav Petkov" <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "security@kernel.org" <security@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        xen-devel <xen-devel@lists.xen.org>, <stable@vger.kernel.org>,
        Jan Beulich <jbeulich@suse.com>, Sasha Levin <sasha.levin@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH v6 1/4] x86/xen: Probe target addresses in
 set_aliased_prot before the hypercall
References: <cover.1438291540.git.luto@kernel.org>
 <0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.luto@kernel.org>
In-Reply-To: <0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.luto@kernel.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 744
Lines: 20

On 30/07/15 22:31, Andy Lutomirski wrote:
> The update_va_mapping hypercall can fail if the VA isn't present in
> the guest's page tables.  Under certain loads, this can result in an
> OOPS when the target address is in unpopulated vmap space.
> 
> While we're at it, add comments to help explain what's going on.
> 
> This isn't a great long-term fix.  This code should probably be
> changed to use something like set_memory_ro.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

Thanks.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/