Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbbGaMB1 (ORCPT ); Fri, 31 Jul 2015 08:01:27 -0400 Received: from mga02.intel.com ([134.134.136.20]:12865 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbbGaMBZ (ORCPT ); Fri, 31 Jul 2015 08:01:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,584,1432623600"; d="scan'208";a="739511252" Message-ID: <1438344078.11322.46.camel@intel.com> Subject: Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol From: Matt Fleming To: joeyli CC: Pavel Machek , "Lee, Chun-Yi" , , , , "Rafael J. Wysocki" , "Matthew Garrett" , Len Brown , "Josh Boyer" , Vojtech Pavlik , Jiri Kosina , "H. Peter Anvin" Date: Fri, 31 Jul 2015 13:01:18 +0100 In-Reply-To: <20150731095854.GC13113@linux-rxt1.site> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-6-git-send-email-jlee@suse.com> <20150728122853.GB12681@amd> <20150731095854.GC13113@linux-rxt1.site> Organization: Intel Corporation (UK) Ltd. - Registered No. 1134945 - Pipers Way, Swindon SN3 1RJ Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [163.33.239.180] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 61 On Fri, 2015-07-31 at 17:58 +0800, joeyli wrote: > > > > Can you do something to avoid each function having two very similar > > versions of these functions? > > > > They are similar but I want follow the style in eboot.c. > On the other hand, it's earlier to locate problem on 32-bit or 64-bit EFI. > > So, I will keep the above codes. FWIW, I think that's fine. I would happily accept a patch to cleanup the duplication, but I don't think that needs to be a prerequisite for this support. I've no problem with the duplication right now. > > > > > --- a/include/linux/efi.h > > > +++ b/include/linux/efi.h > > > @@ -427,6 +427,16 @@ typedef struct { > > > #define EFI_PCI_IO_ATTRIBUTE_VGA_PALETTE_IO_16 0x20000 > > > #define EFI_PCI_IO_ATTRIBUTE_VGA_IO_16 0x40000 > > > > > > +typedef struct { > > > + u32 get_info; > > > + u32 get_rng; > > > +} efi_rng_protocol_32; > > > + > > > +typedef struct { > > > + u64 get_info; > > > + u64 get_rng; > > > +} efi_rng_protocol_64; > > > > We don't typedef structs usually... > > > > Make it union so you can have just one > > > > I want to follow the style as efi_pci_io_protocolxxx in efi.h. > So I will keep it. Yeah, consistency is better here than sticking with the general Linux coding style rules. > > > + switch (status) { > > > + case EFI_SUCCESS: > > > + str = "EFI_SUCCESS"; > > > + break; > > > > Can you use macros to reduce code duplication here? > > Pavel > I will try to reduce duplicate code. Take a look at __stringify(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/