Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbGaNhl (ORCPT ); Fri, 31 Jul 2015 09:37:41 -0400 Received: from foss.arm.com ([217.140.101.70]:45070 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbbGaNhi (ORCPT ); Fri, 31 Jul 2015 09:37:38 -0400 Date: Fri, 31 Jul 2015 14:37:07 +0100 From: Mark Rutland To: chunfeng yun Cc: Mathias Nyman , Rob Herring , Matthias Brugger , Felipe Balbi , Sascha Hauer , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Roger Quadros , "linux-usb@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , John Crispin , Daniel Kurtz Subject: Re: [PATCH v3 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Message-ID: <20150731133707.GB25118@leverpostej> References: <1437573945-31586-1-git-send-email-chunfeng.yun@mediatek.com> <1437573945-31586-3-git-send-email-chunfeng.yun@mediatek.com> <20150722142208.GC15809@leverpostej> <1437882325.3040.22.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437882325.3040.22.camel@mhfsdcap03> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 48 Hi, > > > + - mediatek,usb-wakeup: to access usb wakeup control register > > > > What exactly does this property imply? > > > There are some control registers for usb wakeup which are put in another > module, here to get the node of that module, and then use regmap and > syscon to operate it. Ok. You need to specify the type of this property (i.e. that it is a phandle to a syscon node). The description makes it sound like a boolean. > > > > + - mediatek,wakeup-src: 1: ip sleep wakeup mode; 2: line state wakeup > > > + mode; others means don't enable wakeup source of usb > > > > This sounds like configuration rather than a hardware property. Why do > > you think this needs to be in the DT? > > > Yes, it's better to put it in the DT. That doesn't answer my question. _why_ do you think this needs to be in the DT? What do you think is better for it being there? > > > > + - mediatek,u2port-num: the number should not greater than the number > > > + of phys > > > > What exactly does this property imply? > > > On some platform, it only makes use of partial usb ports, so disable > others to save power. What exactly do you mean by "partial USB ports"? If a phy isn't wired up, it won't be listed in the phys property, if it is then disabling it sounds like a run-time decision. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/