Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434AbbGaOFJ (ORCPT ); Fri, 31 Jul 2015 10:05:09 -0400 Received: from goliath.siemens.de ([192.35.17.28]:54708 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754394AbbGaOFC (ORCPT ); Fri, 31 Jul 2015 10:05:02 -0400 To: Steven Rostedt , Linux Kernel Mailing List From: Jan Kiszka Subject: [PATCH] trace-cmd: Leave out absolute addresses to fix bogus symbol resolutions Message-ID: <55BB8086.9080602@siemens.com> Date: Fri, 31 Jul 2015 16:04:54 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 36 On x86, page_fault_* tracepoints report userspace address via kernel symbols because all the per-cpu variable offsets are in kallsyms, occupying the lower address space. Fix this by skipping over absolute addresses while processing kallsyms. Signed-off-by: Jan Kiszka --- trace-util.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/trace-util.c b/trace-util.c index 8a81dd0..da20e4c 100644 --- a/trace-util.c +++ b/trace-util.c @@ -434,8 +434,12 @@ void parse_proc_kallsyms(struct pevent *pevent, if (mod) mod[strlen(mod) - 1] = 0; - /* Hack for arm arch that adds a lot of bogus '$a' functions */ - if (func[0] != '$') + /* + * Hacks for + * - arm arch that adds a lot of bogus '$a' functions + * - x86-64 that reports per-cpu variable offsets as absolute + */ + if (func[0] != '$' && ch != 'A') pevent_register_function(pevent, func, addr, mod); free(func); free(mod); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/