Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbbGaOOk (ORCPT ); Fri, 31 Jul 2015 10:14:40 -0400 Received: from www.linutronix.de ([62.245.132.108]:52682 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbbGaOOi (ORCPT ); Fri, 31 Jul 2015 10:14:38 -0400 Date: Fri, 31 Jul 2015 16:14:14 +0200 (CEST) From: Thomas Gleixner To: yalin wang cc: Neil Horman , Andrew Morton , David Kershner , tj@kernel.org, laijs@cn.fujitsu.com, nacc@linux.vnet.ibm.com, mingo@redhat.com, open list , jes.sorensen@redhat.com, sparmaintainer@unisys.com Subject: Re: [PATCH v2] kthread: Export kthread functions In-Reply-To: Message-ID: References: <1437777920-31156-1-git-send-email-david.kershner@unisys.com> <1438099141-8614-1-git-send-email-david.kershner@unisys.com> <20150728142748.a756d7540ad5cdaf4c9efc9e@linux-foundation.org> <20150730120223.GA27430@hmsreliant.think-freely.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 36 On Fri, 31 Jul 2015, Thomas Gleixner wrote: > On Fri, 31 Jul 2015, yalin wang wrote: > > it is optimised to 2 instructions , > > > > this is my patch, hope can be merged : > > We are not exposing the internals of kthread management. Period. And your 'optimization' is completely bogus: Before your modification: size kernel/built-in.o text data bss dec hex filename 1091514 141498 341928 1574940 18081c ../build/kernel/built-in.o After: text data bss dec hex filename 1091664 141498 341928 1575090 1808b2 ../build/kernel/built-in.o That's an increase of text size by 150 byte. Interesting optimization. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/