MIME-Version: 1.0
In-Reply-To: <tip-ba3e127ec105e790eeec4034d9769e018e4a1b54@git.kernel.org>
References: <1438148483-11932-7-git-send-email-brgerst@gmail.com>
	<tip-ba3e127ec105e790eeec4034d9769e018e4a1b54@git.kernel.org>
Date: Fri, 31 Jul 2015 10:53:54 -0400
Message-ID: <CAMzpN2i8pCANnbgo93wDn-uBvBKMqyLbLzGsd5wzQNh-dwFsaQ@mail.gmail.com>
Subject: Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes
From: Brian Gerst <brgerst@gmail.com>
To: Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@amacapital.net>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-tip-commits@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2038
Lines: 55

On Fri, Jul 31, 2015 at 10:04 AM, tip-bot for Brian Gerst
<tipbot@zytor.com> wrote:
> Commit-ID:  ba3e127ec105e790eeec4034d9769e018e4a1b54
> Gitweb:     http://git.kernel.org/tip/ba3e127ec105e790eeec4034d9769e018e4a1b54
> Author:     Brian Gerst <brgerst@gmail.com>
> AuthorDate: Wed, 29 Jul 2015 01:41:21 -0400
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Fri, 31 Jul 2015 13:31:10 +0200
>
> x86/vm86: Clean up vm86.h includes
>
> vm86.h was being implicitly included in alot of places via
> processor.h, which in turn got it from math_emu.h.  Break that
> chain and explicitly include vm86.h in all files that need it.
> Also remove unused vm86 field from math_emu_info.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Denys Vlasenko <dvlasenk@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Link: http://lkml.kernel.org/r/1438148483-11932-7-git-send-email-brgerst@gmail.com
> [ Fixed build failure. ]
> Signed-off-by: Ingo Molnar <mingo@kernel.org>


> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index f35ed53..d4cda5e 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1924,6 +1924,9 @@ static void adpt_alpha_info(sysInfo_S* si)
>  #endif
>
>  #if defined __i386__
> +
> +#include <uapi/asm/vm86.h>
> +
>  static void adpt_i386_info(sysInfo_S* si)
>  {
>         // This is all the info we need for now

It would have been better to just remove the the CPU_* defines from
this driver.  boot_cpu_data.x86 is simply the family ID from CPUID,
and nowhere else uses defines like this.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/