Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753280AbbGaP0v (ORCPT ); Fri, 31 Jul 2015 11:26:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40036 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbbGaP0G (ORCPT ); Fri, 31 Jul 2015 11:26:06 -0400 Message-ID: <1438356362.20479.16.camel@redhat.com> Subject: Re: [PATCH net-next 5/9] openvswitch: Add conntrack action From: Hannes Frederic Sowa To: Joe Stringer , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, pablo@netfilter.org, kaber@trash.net, jpettit@nicira.com, pshelar@nicira.com, azhou@nicira.com, jesse@nicira.com, fwestpha@redhat.com, tgraf@noironetworks.com Date: Fri, 31 Jul 2015 17:26:02 +0200 In-Reply-To: <1438279963-29563-6-git-send-email-joestringer@nicira.com> References: <1438279963-29563-1-git-send-email-joestringer@nicira.com> <1438279963-29563-6-git-send-email-joestringer@nicira.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 24 On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: > +static void do_output(struct datapath *dp, struct sk_buff *skb, int > out_port, > + struct sw_flow_key *key) > { > struct vport *vport = ovs_vport_rcu(dp, out_port); > > - if (likely(vport)) > - ovs_vport_send(vport, skb); > - else > + if (likely(vport)) { > + unsigned int mru = OVS_CB(skb)->mru; > + struct dst_entry *orig_dst = dst_clone(skb_dst(skb)); I think you forgot to remove this? Bye, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/