Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753254AbbGaPqf (ORCPT ); Fri, 31 Jul 2015 11:46:35 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:58984 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778AbbGaPq2 (ORCPT ); Fri, 31 Jul 2015 11:46:28 -0400 Date: Fri, 31 Jul 2015 23:46:11 +0800 From: joeyli To: Pavel Machek Cc: "Lee, Chun-Yi" , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Josh Boyer , Vojtech Pavlik , Matt Fleming , Jiri Kosina , "H. Peter Anvin" Subject: Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp Message-ID: <20150731154611.GG2067@linux-rxt1.site> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-2-git-send-email-jlee@suse.com> <20150728120156.GB9518@amd> <20150731100812.GD13113@linux-rxt1.site> <20150731124936.GA5728@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150731124936.GA5728@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1841 Lines: 50 On Fri, Jul 31, 2015 at 02:49:36PM +0200, Pavel Machek wrote: > On Fri 2015-07-31 18:08:12, joeyli wrote: > > On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote: > > > On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote: > > > > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate > > > > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes), > > > > this size will be also applied to the length of HMAC key. > > > > > > > > In addition, add HIBERNATE_VERIFICATION kernel config. > > > > > > > > Signed-off-by: Lee, Chun-Yi > > > > --- > > > > include/linux/suspend.h | 5 +++++ > > > > kernel/power/Kconfig | 13 +++++++++++++ > > > > kernel/power/power.h | 1 + > > > > 3 files changed, 19 insertions(+) > > > > > > > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h > > > > index 5efe743..6cd2a48 100644 > > > > --- a/include/linux/suspend.h > > > > +++ b/include/linux/suspend.h > > > > @@ -327,6 +327,11 @@ struct platform_hibernation_ops { > > > > }; > > > > > > > > #ifdef CONFIG_HIBERNATION > > > > + > > > > +/* HMAC Algorithm of Hibernate Signature */ > > > > +#define SWSUSP_HMAC "hmac(sha1)" > > > > +#define SWSUSP_DIGEST_SIZE 20 > > > > > > I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere. > > > > > > > SWSUSP is shorter than HIBERNATION, and there have some codes in hibernate > > are also using swsusp. I still want to use it. > > Yes, its shorter, but its old name we are trying to move away > from. Please do the same. > Pavel OK~ I will rename. Thanks Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/