Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbGaQFw (ORCPT ); Fri, 31 Jul 2015 12:05:52 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:49958 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbbGaQFu (ORCPT ); Fri, 31 Jul 2015 12:05:50 -0400 Date: Sat, 1 Aug 2015 00:05:36 +0800 From: joeyli To: Matt Fleming Cc: Pavel Machek , "Lee, Chun-Yi" , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Matthew Garrett , Len Brown , Josh Boyer , Vojtech Pavlik , Jiri Kosina , "H. Peter Anvin" Subject: Re: [RFC PATCH 05/16] x86/efi: Get entropy through EFI random number generator protocol Message-ID: <20150731160536.GH2067@linux-rxt1.site> References: <1437056730-15247-1-git-send-email-jlee@suse.com> <1437056730-15247-6-git-send-email-jlee@suse.com> <20150728122853.GB12681@amd> <20150731095854.GC13113@linux-rxt1.site> <1438344078.11322.46.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438344078.11322.46.camel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1991 Lines: 69 On Fri, Jul 31, 2015 at 01:01:18PM +0100, Matt Fleming wrote: > On Fri, 2015-07-31 at 17:58 +0800, joeyli wrote: > > > > > > Can you do something to avoid each function having two very similar > > > versions of these functions? > > > > > > > They are similar but I want follow the style in eboot.c. > > On the other hand, it's earlier to locate problem on 32-bit or 64-bit EFI. > > > > So, I will keep the above codes. > > FWIW, I think that's fine. I would happily accept a patch to cleanup the > duplication, but I don't think that needs to be a prerequisite for this > support. > > I've no problem with the duplication right now. > Thanks > > > > > > > --- a/include/linux/efi.h > > > > +++ b/include/linux/efi.h > > > > @@ -427,6 +427,16 @@ typedef struct { > > > > #define EFI_PCI_IO_ATTRIBUTE_VGA_PALETTE_IO_16 0x20000 > > > > #define EFI_PCI_IO_ATTRIBUTE_VGA_IO_16 0x40000 > > > > > > > > +typedef struct { > > > > + u32 get_info; > > > > + u32 get_rng; > > > > +} efi_rng_protocol_32; > > > > + > > > > +typedef struct { > > > > + u64 get_info; > > > > + u64 get_rng; > > > > +} efi_rng_protocol_64; > > > > > > We don't typedef structs usually... > > > > > > Make it union so you can have just one > > > > > > > I want to follow the style as efi_pci_io_protocolxxx in efi.h. > > So I will keep it. > > Yeah, consistency is better here than sticking with the general Linux > coding style rules. > > > > > + switch (status) { > > > > + case EFI_SUCCESS: > > > > + str = "EFI_SUCCESS"; > > > > + break; > > > > > > Can you use macros to reduce code duplication here? > > > Pavel > > I will try to reduce duplicate code. > > Take a look at __stringify(). > Thanks for suggestion, I will look at it. Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/