Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbbGaQdd (ORCPT ); Fri, 31 Jul 2015 12:33:33 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35071 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbbGaQdb (ORCPT ); Fri, 31 Jul 2015 12:33:31 -0400 Subject: Re: [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter To: Kaixu Xia , davem@davemloft.net, acme@kernel.org, mingo@redhat.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org, daniel@iogearbox.net References: <1438343970-11974-1-git-send-email-xiakaixu@huawei.com> Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org From: Alexei Starovoitov Message-ID: <55BBA359.2060601@plumgrid.com> Date: Fri, 31 Jul 2015 09:33:29 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438343970-11974-1-git-send-email-xiakaixu@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 26 On 7/31/15 4:59 AM, Kaixu Xia wrote: > changes in V5: > - move struct fd_array_map_ops* fd_ops to bpf_map; > - move array perf event decrement refcnt function to > map_free; > - fix the NULL ptr of perf_event_get(); > - move bpf_perf_event_read() to kernel/bpf/bpf_trace.c; > - get rid of the remaining struct bpf_prog; > - move the unnecessay cast on void *; overall looks good. few nits here and there... With amount of changes to bpf core in patch 1 it definitely needs to go via net-next, otherwise merge window conflicts will be nasty. Ingo, Peter, could you please review perf bits in patches 2 and 3, so we can take the whole set via net-next. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/