Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbbGaQjj (ORCPT ); Fri, 31 Jul 2015 12:39:39 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33480 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbbGaQji (ORCPT ); Fri, 31 Jul 2015 12:39:38 -0400 Subject: Re: [PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event To: Kaixu Xia , davem@davemloft.net, acme@kernel.org, mingo@redhat.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org, daniel@iogearbox.net References: <1438343970-11974-1-git-send-email-xiakaixu@huawei.com> <1438343970-11974-3-git-send-email-xiakaixu@huawei.com> Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org From: Alexei Starovoitov Message-ID: <55BBA4C8.1030805@plumgrid.com> Date: Fri, 31 Jul 2015 09:39:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438343970-11974-3-git-send-email-xiakaixu@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 16 On 7/31/15 4:59 AM, Kaixu Xia wrote: > + /* > + * prevent some crazy events so we can make our life easier > + */ > + if (event->attr.type != PERF_TYPE_RAW && > + event->attr.type != PERF_TYPE_HARDWARE) { > + perf_event_release_kernel(event); > + return ERR_PTR(-EINVAL); > + } either remove the comment and make it clean. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/