Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752010AbbGaTCB (ORCPT ); Fri, 31 Jul 2015 15:02:01 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35171 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbbGaTB7 (ORCPT ); Fri, 31 Jul 2015 15:01:59 -0400 MIME-Version: 1.0 From: Valentin Rothberg Date: Fri, 31 Jul 2015 21:01:29 +0200 Message-ID: Subject: ARM: SAMSUNG: mach-s3c24xx: setup-camif: dead code To: kgene@kernel.org, k.kozlowski@samsung.com, Paul Bolle , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 37 Hi Kukjin, your commit a1bd8d8bb890 ("ARM: SAMSUNG: make local setup-camif in mach-s3c24xx") is in today's linux-next tree (i.e., next-20150731) and it adds the following lines of code with arch/arm/mach-s3c24xx/setup-camif.c: +#ifdef CONFIG_ARCH_S3C24XX + *gpio_start = S3C2410_GPJ(0); + *gpio_reset = S3C2410_GPJ(12); +#else + /* s3c64xx */ + *gpio_start = S3C64XX_GPF(0); + *gpio_reset = S3C64XX_GPF(3); +#endif The problem is that the #else block cannot be compiled at the current state, since the #ifdef block will _always_ be selected by the C preprocessor due to some build constraints from Makefiles, see arch/arm/Makefile line 196: machine-$(CONFIG_ARCH_S3C24XX) Hence CONFIG_ARCH_S3C24XX will always be set when compiling arch/arm/mach-s3c24xx/setup-camif.c. I detected this issue with undertaker-checkpatch from [1]. Kind regards, Valentin [1] https://undertaker.cs.fau.de -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/