Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945943AbbGaUNU (ORCPT ); Fri, 31 Jul 2015 16:13:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755510AbbGaUNP (ORCPT ); Fri, 31 Jul 2015 16:13:15 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Taylor , Marcel Ritter , Filipe Manana , Mark Fasheh Subject: [PATCH 3.14 094/125] Btrfs: fix memory leak in the extent_same ioctl Date: Fri, 31 Jul 2015 12:41:34 -0700 Message-Id: <20150731194030.402761261@linuxfoundation.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <20150731194027.037807932@linuxfoundation.org> References: <20150731194027.037807932@linuxfoundation.org> User-Agent: quilt/0.64 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1758 Lines: 59 3.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Filipe Manana commit 497b4050e0eacd4c746dd396d14916b1e669849d upstream. We were allocating memory with memdup_user() but we were never releasing that memory. This affected pretty much every call to the ioctl, whether it deduplicated extents or not. This issue was reported on IRC by Julian Taylor and on the mailing list by Marcel Ritter, credit goes to them for finding the issue. Reported-by: Julian Taylor Reported-by: Marcel Ritter Signed-off-by: Filipe Manana Reviewed-by: Mark Fasheh Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/ioctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2743,7 +2743,7 @@ out_unlock: static long btrfs_ioctl_file_extent_same(struct file *file, struct btrfs_ioctl_same_args __user *argp) { - struct btrfs_ioctl_same_args *same; + struct btrfs_ioctl_same_args *same = NULL; struct btrfs_ioctl_same_extent_info *info; struct inode *src = file_inode(file); u64 off; @@ -2773,6 +2773,7 @@ static long btrfs_ioctl_file_extent_same if (IS_ERR(same)) { ret = PTR_ERR(same); + same = NULL; goto out; } @@ -2843,6 +2844,7 @@ static long btrfs_ioctl_file_extent_same out: mnt_drop_write_file(file); + kfree(same); return ret; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/