Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbbGaXAz (ORCPT ); Fri, 31 Jul 2015 19:00:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51856 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752994AbbGaXAy (ORCPT ); Fri, 31 Jul 2015 19:00:54 -0400 Date: Fri, 31 Jul 2015 16:00:53 -0700 From: Greg Kroah-Hartman To: green@linuxhacker.ru Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List Subject: Re: [PATCH 06/13] staging/lustre: Drop SEEK_* definition checks Message-ID: <20150731230053.GA22744@kroah.com> References: <1438295284-2307773-1-git-send-email-green@linuxhacker.ru> <1438295284-2307773-7-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438295284-2307773-7-git-send-email-green@linuxhacker.ru> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 59 On Thu, Jul 30, 2015 at 06:27:57PM -0400, green@linuxhacker.ru wrote: > From: Oleg Drokin > > SEEK_DATA and SEEK_HOLE are always defined in the kernel, > drop the definition checks > > Signed-off-by: Oleg Drokin > --- > .../lustre/lustre/include/linux/lustre_compat25.h | 38 ---------------------- > 1 file changed, 38 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h > index d0e8f3c..7d90999 100644 > --- a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h > +++ b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h > @@ -69,37 +69,6 @@ > # define inode_dio_read(i) atomic_inc(&(i)->i_dio_count) > /* inode_dio_done(i) use as-is for read unlock */ > > -static inline int > -ll_quota_on(struct super_block *sb, int off, int ver, char *name, int remount) > -{ > - int rc; > - > - if (sb->s_qcop->quota_on) { > - struct path path; > - > - rc = kern_path(name, LOOKUP_FOLLOW, &path); > - if (!rc) > - return rc; > - rc = sb->s_qcop->quota_on(sb, off, ver > - , &path > - ); > - path_put(&path); > - return rc; > - } else > - return -ENOSYS; > -} > - > -static inline int ll_quota_off(struct super_block *sb, int off, int remount) > -{ > - if (sb->s_qcop->quota_off) { > - return sb->s_qcop->quota_off(sb, off > - ); > - } else > - return -ENOSYS; > -} > - > - > - This code removal doesn't match up with the changelog text, so I can't take this :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/