Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbbHAAij (ORCPT ); Fri, 31 Jul 2015 20:38:39 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35794 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbbHAAih (ORCPT ); Fri, 31 Jul 2015 20:38:37 -0400 From: "Luis R. Rodriguez" To: rth@twiddle.net Cc: ink@jurassic.park.msu.ru, mattst88@gmail.com, will.deacon@arm.com, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, paul.gortmaker@windriver.com, mingo@kernel.org, linux-next@vger.kernel.org, "Luis R. Rodriguez" Subject: [RFC] alpha: use asm-generic/io.h Date: Fri, 31 Jul 2015 17:38:29 -0700 Message-Id: <1438389509-16908-1-git-send-email-mcgrof@do-not-panic.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 50 From: "Luis R. Rodriguez" Since alpha does not include asm-generic/io.h it would mean alpha folks have to always carefully monitor asm-generic patches and before they get merged make sure their own arch implementation solution gets added. By using asm-generic/io.h alpha gets sensible defaults, in this case ioremap_uc() would be one example, where by default it would return NULL, so not implemented. When alpha folks get a chance then they can add the appropriate implementation. Reported-by: Guenter Roeck Cc: Paul Gortmaker Signed-off-by: Luis R. Rodriguez --- The easy solution *for now* is to just do: #define ioremap_uc ioremap_nocache *But* that would have to be done for any other asm-generic/io.h collateral evolution, this on the other hand, would get it right for alpha from the get-go -- so I ask -- can this please be tested and if it is OK then consider it be merged? If we can't add asm-generic/io.h then the above define replacement would be the way to go. arch/alpha/include/asm/io.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h index f05bdb4b1cb9..16a5bda42750 100644 --- a/arch/alpha/include/asm/io.h +++ b/arch/alpha/include/asm/io.h @@ -581,4 +581,6 @@ extern void outsl (unsigned long port, const void *src, unsigned long count); #endif /* __KERNEL__ */ +#include + #endif /* __ALPHA_IO_H */ -- 2.3.2.209.gd67f9d5.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/