Message-ID: <1438389906.19345.101.camel@freescale.com>
Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver
From: Scott Wood <scottwood@freescale.com>
To: <Yuantian.Tang@freescale.com>
CC: <b07421@freescale.com>, <linuxppc-dev@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Chenhui Zhao <chenhui.zhao@freescale.com>
Date: Fri, 31 Jul 2015 19:45:06 -0500
In-Reply-To: <1435304656-34505-1-git-send-email-Yuantian.Tang@freescale.com>
References: <1435304656-34505-1-git-send-email-Yuantian.Tang@freescale.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
BY1PR03MB1483: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2015 00:45:12.3839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1483
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 834
Lines: 26

On Fri, 2015-06-26 at 15:44 +0800, Yuantian.Tang@freescale.com wrote:
> +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
> +{
> +     if (enable)
> +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> +     else
> +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> +}
> +
> +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
> +{
> +     if (enable)
> +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> +     else
> +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> +}

Why do these take "u32 *mask" instead of "u32 mask"?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/