Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbbHABA0 (ORCPT ); Fri, 31 Jul 2015 21:00:26 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:39303 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbHABAW (ORCPT ); Fri, 31 Jul 2015 21:00:22 -0400 Message-ID: <55BC1A1F.4090702@roeck-us.net> Date: Fri, 31 Jul 2015 18:00:15 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Luis R. Rodriguez" , rth@twiddle.net CC: ink@jurassic.park.msu.ru, mattst88@gmail.com, will.deacon@arm.com, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, mingo@kernel.org, linux-next@vger.kernel.org, "Luis R. Rodriguez" Subject: Re: [RFC] alpha: use asm-generic/io.h References: <1438389509-16908-1-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1438389509-16908-1-git-send-email-mcgrof@do-not-panic.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1937 Lines: 55 On 07/31/2015 05:38 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Since alpha does not include asm-generic/io.h it would mean > alpha folks have to always carefully monitor asm-generic patches > and before they get merged make sure their own arch implementation > solution gets added. By using asm-generic/io.h alpha gets sensible > defaults, in this case ioremap_uc() would be one example, where > by default it would return NULL, so not implemented. When alpha > folks get a chance then they can add the appropriate > implementation. > > Reported-by: Guenter Roeck > Cc: Paul Gortmaker > Signed-off-by: Luis R. Rodriguez Doesn't work. Gives me lots of duplicate symbols. Guenter > --- > > The easy solution *for now* is to just do: > > #define ioremap_uc ioremap_nocache > > *But* that would have to be done for any other asm-generic/io.h collateral > evolution, this on the other hand, would get it right for alpha from the > get-go -- so I ask -- can this please be tested and if it is OK then consider > it be merged? > > If we can't add asm-generic/io.h then the above define replacement would > be the way to go. > > arch/alpha/include/asm/io.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h > index f05bdb4b1cb9..16a5bda42750 100644 > --- a/arch/alpha/include/asm/io.h > +++ b/arch/alpha/include/asm/io.h > @@ -581,4 +581,6 @@ extern void outsl (unsigned long port, const void *src, unsigned long count); > > #endif /* __KERNEL__ */ > > +#include > + > #endif /* __ALPHA_IO_H */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/