Message-ID: <1438397837.2097.4.camel@freescale.com>
Subject: Re: [PATCH] powerpc/85xx: add sleep and deep sleep support
From: Scott Wood <scottwood@freescale.com>
To: Chenhui Zhao <chenhui.zhao@freescale.com>
CC: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
        <Jason.Jin@freescale.com>
Date: Fri, 31 Jul 2015 21:57:17 -0500
In-Reply-To: <1437741961-6663-1-git-send-email-chenhui.zhao@freescale.com>
References: <1437741961-6663-1-git-send-email-chenhui.zhao@freescale.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
BN3PR03MB1478: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2015 02:57:24.9952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1478
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1183
Lines: 42

On Fri, 2015-07-24 at 20:46 +0800, Chenhui Zhao wrote:
> +static void mpc85xx_pmc_set_wake(struct device *dev, void *enable)
>  {
>       int ret;
> +     u32 value[2];
> +
> +     if (!device_may_wakeup(dev))
> +             return;
> +
> +     if (!pmc_regs) {
> +             dev_err(dev, "%s: PMC is unavailable\n", __func__);
> +             return;
> +     }
> +
> +     ret = of_property_read_u32_array(dev->of_node, "sleep", value, 2);

This will crash on any device without an of_node.

> +     if (ret) {
> +             dev_dbg(dev, "%s: Can not find the \"sleep\" property.\n",
> +                     __func__);
> +             return;
> +     }
> +
> +     if (*(int *)enable)
> +             pmc_pmcdr_mask &= ~value[1];
> +     else
> +             pmc_pmcdr_mask |= value[1];
> +
> +     if ((value[1] & 0xe0) && (pmc_flag & PMC_LOSSLESS))
> +             pmc_powmgtcsr = POWMGTCSR_LOSSLESS;
> +}

What is 0xe0?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/