Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbbHAHoK (ORCPT ); Sat, 1 Aug 2015 03:44:10 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:35761 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbHAHoH (ORCPT ); Sat, 1 Aug 2015 03:44:07 -0400 Message-ID: <55BC78BE.5020102@samsung.com> Date: Sat, 01 Aug 2015 16:43:58 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar CC: Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH v3 3/5] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 References: <1438368557-2352-1-git-send-email-b.zolnierkie@samsung.com> <1438368557-2352-4-git-send-email-b.zolnierkie@samsung.com> In-Reply-To: <1438368557-2352-4-git-send-email-b.zolnierkie@samsung.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2487 Lines: 62 W dniu 01.08.2015 o 03:49, Bartlomiej Zolnierkiewicz pisze: > The new CPU clock type allows the use of generic CPUfreq driver. > Switch Exynos4x12 to using generic cpufreq driver. > > Also make CPUFREQ_DT config option select Exynos thermal driver > if Exynos platform support is enabled. Why? I think this wasn't in your previous patch. Best regards, Krzysztof > > Please also note that the switch to use the generic cpufreq-dt > driver fixes the minor issue present with the old code (support > for 'boost' mode in the exynos-cpufreq driver was enabled for > all supported SoCs even though 'boost' frequency was provided > only for Exynos4x12 ones). > > Cc: Tomasz Figa > Cc: Kukjin Kim > Cc: Thomas Abraham > Cc: Javier Martinez Canillas > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-exynos/exynos.c | 2 ++ > drivers/cpufreq/Kconfig | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 77ac021..1c47aee 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -227,6 +227,8 @@ static void __init exynos_init_irq(void) > static const struct of_device_id exynos_cpufreq_matches[] = { > { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, > { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, > + { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, > + { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, > { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, > { /* sentinel */ } > }; > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 659879a..bf6d596 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -191,6 +191,7 @@ config CPUFREQ_DT > # if CPU_THERMAL is on and THERMAL=m, CPUFREQ_DT cannot be =y: > depends on !CPU_THERMAL || THERMAL > select PM_OPP > + select EXYNOS_THERMAL if ARCH_EXYNOS > help > This adds a generic DT based cpufreq driver for frequency management. > It supports both uniprocessor (UP) and symmetric multiprocessor (SMP) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/