Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbbHALR3 (ORCPT ); Sat, 1 Aug 2015 07:17:29 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:35326 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbHALR1 (ORCPT ); Sat, 1 Aug 2015 07:17:27 -0400 Date: Sat, 1 Aug 2015 16:47:21 +0530 From: Viresh Kumar To: Bartlomiej Zolnierkiewicz Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH v3 3/5] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Message-ID: <20150801111721.GI899@linux> References: <1438368557-2352-1-git-send-email-b.zolnierkie@samsung.com> <1438368557-2352-4-git-send-email-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438368557-2352-4-git-send-email-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 24 On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote: > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 659879a..bf6d596 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -191,6 +191,7 @@ config CPUFREQ_DT > # if CPU_THERMAL is on and THERMAL=m, CPUFREQ_DT cannot be =y: > depends on !CPU_THERMAL || THERMAL > select PM_OPP > + select EXYNOS_THERMAL if ARCH_EXYNOS > help > This adds a generic DT based cpufreq driver for frequency management. > It supports both uniprocessor (UP) and symmetric multiprocessor (SMP) No, we shouldn't pollute generic Kconfig options with platform specific stuff. Why don't you enable thermal in your .config? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/