Date: Sat, 1 Aug 2015 09:32:21 -0400
From: Neil Horman <nhorman@redhat.com>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Kershner <david.kershner@unisys.com>, tj@kernel.org,
        laijs@cn.fujitsu.com, nacc@linux.vnet.ibm.com, mingo@redhat.com,
        open list <linux-kernel@vger.kernel.org>, jes.sorensen@redhat.com,
        sparmaintainer@unisys.com
Subject: Re: [PATCH v2] kthread: Export kthread functions
Message-ID: <20150801133221.GA6603@neilslaptop.think-freely.org>
References: <1437777920-31156-1-git-send-email-david.kershner@unisys.com>
 <1438099141-8614-1-git-send-email-david.kershner@unisys.com>
 <20150728142748.a756d7540ad5cdaf4c9efc9e@linux-foundation.org>
 <alpine.DEB.2.11.1507291233470.3825@nanos>
 <BC1DBE23-DF3E-49C1-BE59-A81EC98F5B1A@gmail.com>
 <20150730120223.GA27430@hmsreliant.think-freely.org>
 <FC536F44-E3A4-45E0-9B21-4C1CC256F94C@gmail.com>
 <alpine.DEB.2.11.1507311019040.3825@nanos>
 <alpine.DEB.2.11.1507311610180.3825@nanos>
 <6440C9D8-37D8-4E30-89D7-04CB96BC8114@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6440C9D8-37D8-4E30-89D7-04CB96BC8114@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1631
Lines: 54

On Sat, Aug 01, 2015 at 03:12:42PM +0800, yalin wang wrote:
> 
> > 在 2015年7月31日，22:14，Thomas Gleixner <tglx@linutronix.de> 写道：
> > 
> > 
> > On Fri, 31 Jul 2015, Thomas Gleixner wrote:
> > 
> >> On Fri, 31 Jul 2015, yalin wang wrote:
> >>> it is optimised to 2 instructions ,
> >>> 
> >>> this is my patch, hope can be merged :
> >> 
> >> We are not exposing the internals of kthread management. Period.
> > 
> > And your 'optimization' is completely bogus:
> > 
> > Before your modification:
> > 
> > size kernel/built-in.o
> > 
> >   text	   data	    bss	    dec	    hex	filename
> > 1091514	 141498  341928 1574940  18081c	../build/kernel/built-in.o
> > 
> > After:
> > 
> >   text	   data	    bss	    dec	    hex	filename
> > 1091664  141498  341928 1575090  1808b2	../build/kernel/built-in.o
> > 
> > That's an increase of text size by 150 byte. Interesting optimization.
> > 
> > Thanks,
> > 
> > 	tglx
> > 
> > 
> strange,  this is my test result:
> 
> size   built-in.o*
>   text	   data	    bss	    dec	    hex	filename
> 743937	  50786	  56008	 850731	  cfb2b	built-in.o        // with the patch
> 744069	  50786	  56008	 850863	  cfbaf	built-in.o_old  // with out the patch
> 
So you're willing to expose the internals of kthread_park in exchange for the
hope of saving 132 bytes of text.

Thats just dumb.  I agree with tglx, this shouldn't change.

Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/