Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbbHAS7T (ORCPT ); Sat, 1 Aug 2015 14:59:19 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:35006 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbbHAS7R (ORCPT ); Sat, 1 Aug 2015 14:59:17 -0400 Message-ID: <1438455539.3225.29.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 058/221] debugfs: leave freeing a symlink body until inode eviction From: Ben Hutchings To: Luis Henriques Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Al Viro , Joseph Salisbury , Jamie Strandboge Date: Sat, 01 Aug 2015 19:58:59 +0100 In-Reply-To: <20150616163303.GB1877@ares> References: <20150616163303.GB1877@ares> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-g4JiQUMgzQZo0D6wOjmE" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.249 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2250 Lines: 65 --=-g4JiQUMgzQZo0D6wOjmE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-06-16 at 17:33 +0100, Luis Henriques wrote: > On Tue, May 05, 2015 at 02:16:39AM +0100, Ben Hutchings wrote: [...] > > [bwh: Backported to 3.2: > > - Plumb in debugfs_super_operations, which we didn't previously=20 > > define >=20 > It looks like this is introducing a regression[1]. Basically, simply > running df shows an error: >=20 > df: `/sys/kernel/debug': Function not implemented >=20 > Doing 'strace df' shows the following: >=20 > statfs64("/sys/kernel/debug", 84, 0xbfddc6bc) =3D -1 ENOSYS (Function= =20 > not implemented) >=20 > A quick test shows that adding '.statfs =3D simple_statfs' in the > debugfs_super_operations struct fixes the problem, but I'm not sure > that's the right thing to do. [...] It looks right to me. I've queued up this change; thanks a lot. Ben. --=20 Ben Hutchings One of the nice things about standards is that there are so many of them. --=-g4JiQUMgzQZo0D6wOjmE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVb0W8+e/yOyVhhEJAQr0yQ/8CzLrRqOoLQQngHyOR9dDZ5I29vsy3h4g Wnz1H7EYS4O12XnTT6cvLoCqQRkF9toKQlm2PlgB9rsGu50MVD0XrVqFQYuSK6nz sAHsFsk8V/xf0rnZz5byjwx0nD1A6LX+0ZpT6XjMuRUUal0uTk76skR1T02E6C+O wSI/nqmcX1HE6RnvwmYViFf7bdcKyD9iR3lFhPuAZ1N+FXQjjrI0TKvrWOKd8FyT xN47BLCMIJgKvTp2Eg0Kskf12Gz2XqLyx7Q2Xi1GNWLi3pJwxWki5rL9OJSoOu30 yI3SxAm5vCLtOG5FfStl4dCg/r0fAeNSyimQW0pOhjAsHablg7CG27f7EtPZo/kM aTzhyZwll571c6Or+CxRaLEUsUMhPldbGaRcIC3WMCqdv7mnqh7b22+IYAqemuah u6HBIvE2wAWVd9kw+H9KSABhEcrvSNwCr2WMwHD8n9eORSAL5W1ZG8aHV+wRR8/T IYT2jz6ClyRf7WaGEqEQ0SndKF24W9ojL2seIpcxjVSGj+vSGbzfNYMiY471qwHr uXqUjrJj4wNbMZaHbl39cTzl3TVV6eCNKhyqxOKTOTsWUnp2hber8F9mz1/PfZvJ +phqU20LlwuGdENuC1aU6ZnnJR+dceDKcsb/Eb16QPh0rSgrOcmQ0dO5H/nlWEwm +RQkxMpN3UE= =Oi2k -----END PGP SIGNATURE----- --=-g4JiQUMgzQZo0D6wOjmE-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/