Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbbHBBlq (ORCPT ); Sat, 1 Aug 2015 21:41:46 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:49024 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbbHBBlo (ORCPT ); Sat, 1 Aug 2015 21:41:44 -0400 Date: Sun, 2 Aug 2015 02:41:40 +0100 From: Al Viro To: Linus Torvalds Cc: Dominique Martinet , Hugh Dickins , "J. Bruce Fields" , Dominique Martinet , Linux Kernel Mailing List , linux-fsdevel , David Howells Subject: Re: [git pull] vfs.git spurious ENOTDIR fix Message-ID: <20150802014139.GA17109@ZenIV.linux.org.uk> References: <20150731205036.GA3752@nautica> <20150801072603.GV17109@ZenIV.linux.org.uk> <20150802001402.GY17109@ZenIV.linux.org.uk> <20150802002318.GZ17109@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 23 On Sat, Aug 01, 2015 at 05:57:44PM -0700, Linus Torvalds wrote: > Because it's not just that "!d_can_lookup()" case that triggers it, > you also have that pattern in the RCU error case for may_lookup(), and > get_link(). It feels like it might make sense to handle that in caller, but... that goes only for cases when we are *NOT* going to continue after successful transition to non-lazy mode. And these two are not of that sort - we do want to continue rather than restart everything from scratch. BTW, unlazy_walk() has too many arguments, all for the sake of one caller (everything except lookup_fast() calls it with (nd, NULL, 0) as arguments) and it might make sense to split the damn thing in two. I have that in a pending pile since the last cycle, but back then you have asked to stop piling them up and let it settle, so I'd postponed that one along with other cleanups... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/