Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbbHBCjg (ORCPT ); Sat, 1 Aug 2015 22:39:36 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:35086 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbbHBCjc (ORCPT ); Sat, 1 Aug 2015 22:39:32 -0400 MIME-Version: 1.0 In-Reply-To: <20150802014139.GA17109@ZenIV.linux.org.uk> References: <20150731205036.GA3752@nautica> <20150801072603.GV17109@ZenIV.linux.org.uk> <20150802001402.GY17109@ZenIV.linux.org.uk> <20150802002318.GZ17109@ZenIV.linux.org.uk> <20150802014139.GA17109@ZenIV.linux.org.uk> Date: Sat, 1 Aug 2015 19:39:31 -0700 X-Google-Sender-Auth: ihovz8uw9jzG3IrlNnlMfZDdUZo Message-ID: Subject: Re: [git pull] vfs.git spurious ENOTDIR fix From: Linus Torvalds To: Al Viro Cc: Dominique Martinet , Hugh Dickins , "J. Bruce Fields" , Dominique Martinet , Linux Kernel Mailing List , linux-fsdevel , David Howells Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 33 On Sat, Aug 1, 2015 at 6:41 PM, Al Viro wrote: > > It feels like it might make sense to handle that in caller, but... > that goes only for cases when we are *NOT* going to continue after > successful transition to non-lazy mode. And these two are not of > that sort - we do want to continue rather than restart everything > from scratch. Ahh. Yes. I didn't notice that they actually don't return an error at all if the unlazy_walk succeeds, but just continue. Ok, so they really are very different. > BTW, unlazy_walk() has too many arguments, all for the sake of one caller > (everything except lookup_fast() calls it with (nd, NULL, 0) as arguments) > and it might make sense to split the damn thing in two. I have that in > a pending pile since the last cycle, but back then you have asked to stop > piling them up and let it settle, so I'd postponed that one along with other > cleanups... Well, I'd not be against continuing cleanups for 4.3... Well, as long as we can make sure 4.2 is solid first, of course. I'd still like to have Hugh verify that the current -git tree works for his load, but obviously that wasn't easily reproducible, so that will presumably take a few days. Dominique seems to at least not see it any more with that patch. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/