Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbbHBH55 (ORCPT ); Sun, 2 Aug 2015 03:57:57 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47349 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbHBH5z (ORCPT ); Sun, 2 Aug 2015 03:57:55 -0400 Date: Sun, 2 Aug 2015 09:57:53 +0200 From: Pavel Machek To: Matias =?iso-8859-1?Q?Bj=F8rling?= Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen.Bates@pmcs.com, keith.busch@intel.com, Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: Re: [PATCH v6 5/5] nvme: LightNVM support Message-ID: <20150802075753.GH3720@amd> References: <1438082268-13496-1-git-send-email-mb@lightnvm.io> <1438082268-13496-6-git-send-email-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438082268-13496-6-git-send-email-mb@lightnvm.io> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 30 Hi! > +struct nvme_nvm_hb_rw { > + __u8 opcode; > + __u8 flags; > + __u16 command_id; > + __le32 nsid; > + __u64 rsvd2; > + __le64 metadata; > + __le64 prp1; > + __le64 prp2; > + __le64 slba; > + __le16 length; > + __le16 control; > + __le32 dsmgmt; > + __le64 phys_addr; > +}; You are not exporting this to userland, so you can get rid of "__"s. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/