Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbbHBLJt (ORCPT ); Sun, 2 Aug 2015 07:09:49 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:39785 "EHLO mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbbHBLJr (ORCPT ); Sun, 2 Aug 2015 07:09:47 -0400 Date: Sun, 2 Aug 2015 07:09:13 -0400 (EDT) From: Ulrich Obergfell To: Peter Zijlstra Cc: Don Zickus , Jiri Olsa , lkml , Ingo Molnar , Michal Hocko , Stephane Eranian , Andi Kleen , Paul Bunyan Message-ID: <366054547.2544162.1438513753610.JavaMail.zimbra@redhat.com> In-Reply-To: <20150801162522.GO2859@worktop.programming.kicks-ass.net> References: <1438343805-29771-1-git-send-email-jolsa@kernel.org> <20150731153656.GB42272@redhat.com> <110159750.2156696.1438434352724.JavaMail.zimbra@redhat.com> <20150801162522.GO2859@worktop.programming.kicks-ass.net> Subject: Re: [PATCH] watchdog: Fix race on single cpu boot MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.36.7.147] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF22 (Linux)/8.0.6_GA_5922) Thread-Topic: watchdog: Fix race on single cpu boot Thread-Index: OtEpAzwFod1zyWKUKc4R5pqmI7bt1g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1948 Lines: 53 Peter, >> I posted the patch set here: >> >> https://lkml.org/lkml/2015/8/1/64 >> https://lkml.org/lkml/2015/8/1/65 >> https://lkml.org/lkml/2015/8/1/66 >> https://lkml.org/lkml/2015/8/1/67 >> https://lkml.org/lkml/2015/8/1/68 > > If only you didn't use lkml.org links, that site is flaky beyond > unusable. > > Please use lkml.kernel.org/r/$msgid, that way people actually have a > chance of getting a working link and/or finding it in their local > archive. I apologize for the inconvenience. The following links redirect to marc.info: - [PATCH 0/4] watchdog: avoid races in watchdog_nmi_{en|disable} functions lkml.kernel.org/r/1438433365-2979-1-git-send-email-uobergfe@redhat.com - [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() lkml.kernel.org/r/1438433365-2979-2-git-send-email-uobergfe@redhat.com - [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume() lkml.kernel.org/r/1438433365-2979-3-git-send-email-uobergfe@redhat.com This part of the series has already received a comment. The suggestion is to introduce different function names to avoid confusion with the watchdog subsystem, so I propose lockup_detector_suspend() instead of watchdog_suspend() lockup_detector_resume() instead of watchdog_resume() which would be consistent with the existing name lockup_detector_init(). - [PATCH 3/4] watchdog: use park/unpark functions in update_watchdog_all_cpus() lkml.kernel.org/r/1438433365-2979-4-git-send-email-uobergfe@redhat.com - [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug() lkml.kernel.org/r/1438433365-2979-5-git-send-email-uobergfe@redhat.com Regards, Uli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/