Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbbHBPn4 (ORCPT ); Sun, 2 Aug 2015 11:43:56 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54562 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbbHBPny (ORCPT ); Sun, 2 Aug 2015 11:43:54 -0400 Date: Sun, 2 Aug 2015 17:43:52 +0200 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Viresh Kumar , Dmitry Torokhov , akpm@linux-foundation.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Hans de Goede , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , Masaki Ota Subject: Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Message-ID: <20150802154352.GA28860@amd> References: <20150731165841.GD5613@dtor-ws> <20150801112251.GK899@linux> <201508011344.59372@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201508011344.59372@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 36 On Sat 2015-08-01 13:44:59, Pali Roh?r wrote: > On Saturday 01 August 2015 13:22:51 Viresh Kumar wrote: > > On 31-07-15, 09:58, Dmitry Torokhov wrote: > > > On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote: > > > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and > > > > there is no need to do that again from its callers. Drop it. > > > > > > I'd rather keep it as it documents the expected behavior and double > > > unlikely should work just fine. > > > > TBH, I don't really agree that it is there for documentation. The > > only purpose of such compiler flags is to try make code more > > efficient. > > > > Anyway, I got to this series as someone asked me to fix this for one > > of my patches which used unlikely(IS_ERR_OR_NULL()). And so I > > thought about fixing all sites that are doing double unlikely (that > > shouldn't hurt for sure). > > > > I will leave it to you. > > I think that unlikely() macro here make code more readable. Yes, it is > also for compiler optimization, but also for me it looks like Clean Code > pattern -- is not it? People know that errors are unlikely, no need to tell them. I'd remove it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/