Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbbHBQce (ORCPT ); Sun, 2 Aug 2015 12:32:34 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45011 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbbHBQcd (ORCPT ); Sun, 2 Aug 2015 12:32:33 -0400 Subject: Re: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver To: Dan Carpenter , Teodora Baluta References: <1437400350-25960-1-git-send-email-teodora.baluta@intel.com> <1437400350-25960-3-git-send-email-teodora.baluta@intel.com> <20150720141424.GJ5422@mwanda> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, daniel.baluta@intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <55BE461E.9000200@kernel.org> Date: Sun, 2 Aug 2015 17:32:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150720141424.GJ5422@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 45 On 20/07/15 15:14, Dan Carpenter wrote: > On Mon, Jul 20, 2015 at 04:52:30PM +0300, Teodora Baluta wrote: >> +static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo, >> + int index, int *val) >> +{ >> + switch (index) { >> + case AXIS_X: >> + *val = (raw[AXIS_X] - nfo) * 1000 / sens[AXIS_X]; >> + break; >> + case AXIS_Y: >> + *val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y]; >> + break; >> + case AXIS_Z: >> + *val = (raw[AXIS_Z] - nfo) * 1000 / sens[AXIS_Z]; >> + break; >> + default: >> + return -EINVAL; >> + } >> + >> + return 0; >> +} > > We never pass invalid indexes here so this could be replaced with: > > static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo, > int index, int *val) > { > *val = (raw[index] - nfo) * 1000 / sens[index]; > return 0; Even better change the function signature and don't return anything at all perhaps? Anyhow, definitely worth making this change. > } > > regards, > dan carpenter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/