Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbbHBRy4 (ORCPT ); Sun, 2 Aug 2015 13:54:56 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:39876 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbHBRyz (ORCPT ); Sun, 2 Aug 2015 13:54:55 -0400 Message-ID: <55BE5968.3050506@tronnes.org> Date: Sun, 02 Aug 2015 19:54:48 +0200 From: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Fabio Falzoi , thomas.petazzoni@free-electrons.com CC: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller References: <55B0CB5E.8070808@tronnes.org> <1438527425-17419-1-git-send-email-fabio.falzoi84@gmail.com> In-Reply-To: <1438527425-17419-1-git-send-email-fabio.falzoi84@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 27 Den 02.08.2015 16:57, skrev Fabio Falzoi: > Use a struct flexfb_lcd_controller to holds chip properties, instead of > relying on a long 'if - else if' chain. > This allows to: > - use a simple linear search to verify if a certain LCD controller > model is supported or not. > - add support for a new LCD chip controller simply defining a new > flexfb_lcd_controller struct. > > Signed-off-by: Fabio Falzoi > Acked-by: Noralf Trønnes > --- Seems I wasn't clear enough, you could use my ack if you put struct flexfb_lcd_controller inside the driver and not in fbtft.h Noralf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/