Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbbHBR4B (ORCPT ); Sun, 2 Aug 2015 13:56:01 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:34088 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbbHBRz7 (ORCPT ); Sun, 2 Aug 2015 13:55:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1438510340-21568-1-git-send-email-barletz@gmail.com> <55BDFA5C.3040506@cogentembedded.com> Date: Sun, 2 Aug 2015 10:55:58 -0700 Message-ID: Subject: Re: [PATCH] Check return code from pdc20621_i2c_read() From: Tomer Barletz To: Sergei Shtylyov Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 41 Re-sending in plain-text. On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov wrote: > Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead. > Yeah, not sure what I was drinking before writing this 0x%d thing... Regarding the pr_err() - it is not used at all in this file, and printk() is used instead. Wouldn't it be better to leave it with printk for this change, then have another change that replaces printk()s with pr_err()s? --Tomer On Sun, Aug 2, 2015 at 10:53 AM, Tomer Barletz wrote: > > On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov > wrote: > >> Please use pr_err() instead. And "0x%d" makes no sense at all, please >> use "%#x" instead. >> > > Yeah, not sure what I was drinking before writing this 0x%d thing... > > Regarding the pr_err() - it is not used at all in this file, and printk() is > used instead. Wouldn't it be better to leave it with printk for this change, > then have another change that replaces printk()s with pr_err()s? > > --Tomer > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/