Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751748AbbHBSDs (ORCPT <rfc822;w@1wt.eu>);
	Sun, 2 Aug 2015 14:03:48 -0400
Received: from smtprelay0011.hostedemail.com ([216.40.44.11]:33536 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751093AbbHBSDr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 2 Aug 2015 14:03:47 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: air01_5af56415ccc03
X-Filterd-Recvd-Size: 1730
Message-ID: <1438538623.1301.29.camel@perches.com>
Subject: Re: [PATCH] Check return code from pdc20621_i2c_read()
From: Joe Perches <joe@perches.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, tj@kernel.org,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sun, 02 Aug 2015 11:03:43 -0700
In-Reply-To: <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
References: <1438510340-21568-1-git-send-email-barletz@gmail.com>
	 <55BDFA5C.3040506@cogentembedded.com>
	 <CAO-S75CRyh=FPbeTJMZWiYTvpd_wn57f4eGQgOHW2p16+9ANhQ@mail.gmail.com>
	 <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.16.0-fta1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 897
Lines: 24

On Sun, 2015-08-02 at 10:55 -0700, Tomer Barletz wrote:
> Re-sending in plain-text.
> 
> On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> 
> >    Please use pr_err() instead. And "0x%d" makes no sense at all, 
> > please use "%#x" instead.
> > 
> 
> Yeah, not sure what I was drinking before writing this 0x%d thing...
> 
> Regarding the pr_err() - it is not used at all in this file, and
> printk() is used instead. Wouldn't it be better to leave it with
> printk for this change, then have another change that replaces
> printk()s with pr_err()s?

Where possible, it'd be better to use ata_dev_<level>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/