Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbbHBTaI (ORCPT ); Sun, 2 Aug 2015 15:30:08 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:21550 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbHBTaF (ORCPT ); Sun, 2 Aug 2015 15:30:05 -0400 X-IronPort-AV: E=Sophos;i="5.15,596,1432591200"; d="scan'208";a="172438333" Date: Sun, 2 Aug 2015 21:30:00 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Sean O. Stalley" cc: corbet@lwn.net, vinod.koul@intel.com, bhelgaas@google.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.cz, akpm@linux-foundation.org, bigeasy@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, cocci@systeme.lip6.fr Subject: Re: [PATCH v2 4/4] coccinelle: mm: scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci In-Reply-To: <1438371404-3219-5-git-send-email-sean.stalley@intel.com> Message-ID: References: <1438371404-3219-1-git-send-email-sean.stalley@intel.com> <1438371404-3219-5-git-send-email-sean.stalley@intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3029 Lines: 113 Acked-by: Julia Lawall On Fri, 31 Jul 2015, Sean O. Stalley wrote: > add [pci|dma]_pool_zalloc coccinelle check. > replaces instances of [pci|dma]_pool_alloc() followed by memset(0) > with [pci|dma]_pool_zalloc(). > > Signed-off-by: Sean O. Stalley > --- > .../coccinelle/api/alloc/pool_zalloc-simple.cocci | 84 ++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > > diff --git a/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > new file mode 100644 > index 0000000..9b7eb32 > --- /dev/null > +++ b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > @@ -0,0 +1,84 @@ > +/// > +/// Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0 > +/// > +// Copyright: (C) 2015 Intel Corp. GPLv2. > +// Options: --no-includes --include-headers > +// > +// Keywords: dma_pool_zalloc, pci_pool_zalloc > +// > + > +virtual context > +virtual patch > +virtual org > +virtual report > + > +//---------------------------------------------------------- > +// For context mode > +//---------------------------------------------------------- > + > +@depends on context@ > +expression x; > +statement S; > +@@ > + > +* x = \(dma_pool_alloc\|pci_pool_alloc\)(...); > + if ((x==NULL) || ...) S > +* memset(x,0, ...); > + > +//---------------------------------------------------------- > +// For patch mode > +//---------------------------------------------------------- > + > +@depends on patch@ > +expression x; > +expression a,b,c; > +statement S; > +@@ > + > +- x = dma_pool_alloc(a,b,c); > ++ x = dma_pool_zalloc(a,b,c); > + if ((x==NULL) || ...) S > +- memset(x,0,...); > + > +@depends on patch@ > +expression x; > +expression a,b,c; > +statement S; > +@@ > + > +- x = pci_pool_alloc(a,b,c); > ++ x = pci_pool_zalloc(a,b,c); > + if ((x==NULL) || ...) S > +- memset(x,0,...); > + > +//---------------------------------------------------------- > +// For org and report mode > +//---------------------------------------------------------- > + > +@r depends on org || report@ > +expression x; > +expression a,b,c; > +statement S; > +position p; > +@@ > + > + x = @p\(dma_pool_alloc\|pci_pool_alloc\)(a,b,c); > + if ((x==NULL) || ...) S > + memset(x,0, ...); > + > +@script:python depends on org@ > +p << r.p; > +x << r.x; > +@@ > + > +msg="%s" % (x) > +msg_safe=msg.replace("[","@(").replace("]",")") > +coccilib.org.print_todo(p[0], msg_safe) > + > +@script:python depends on report@ > +p << r.p; > +x << r.x; > +@@ > + > +msg="WARNING: *_pool_zalloc should be used for %s, instead of *_pool_alloc/memset" % (x) > +coccilib.report.print_report(p[0], msg) > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/