Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbbHBUWY (ORCPT ); Sun, 2 Aug 2015 16:22:24 -0400 Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:42907 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751605AbbHBUWW (ORCPT ); Sun, 2 Aug 2015 16:22:22 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3868:3873:4321:4605:5007:6119:6261:7903:8603:10004:10400:10848:11026:11232:11658:11914:12043:12517:12519:12679:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: swim62_88dedbbf9c926 X-Filterd-Recvd-Size: 2140 Message-ID: <1438546939.29569.0.camel@perches.com> Subject: Re: [PATCH] Check return code from pdc20621_i2c_read() From: Joe Perches To: Tomer Barletz Cc: Sergei Shtylyov , tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 02 Aug 2015 13:22:19 -0700 In-Reply-To: References: <1438510340-21568-1-git-send-email-barletz@gmail.com> <55BDFA5C.3040506@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.16.0-fta1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 26 On Sun, 2015-08-02 at 10:55 -0700, Tomer Barletz wrote: > On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov > wrote: > > > Please use pr_err() instead. And "0x%d" makes no sense at all, > > please use "%#x" instead. > > > > Yeah, not sure what I was drinking before writing this 0x%d thing... btw: you and a few others ([dui]: debugging under the influence?): $ git grep -n -E "0x[\*\d\.]*%[dui]" drivers/block/DAC960.c:2957: DAC960_Error("IO port 0x%d busy for Controller at\n", drivers/block/DAC960.c:2993: DAC960_Error("IO port 0x%d busy for Controller at\n", drivers/block/cciss.c:3857: dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n", drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:523: mfc_debug(2, "stream buf addr: 0x%08lx, size: 0x%d\n", drivers/misc/sgi-gru/grumain.c:286: gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n", sound/soc/atmel/atmel_ssc_dai.c:293: pr_debug("atmel_ssc_startup: SSC_SR=0x%u\n", I'll send a few patches... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/