Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751783AbbHCEcQ (ORCPT ); Mon, 3 Aug 2015 00:32:16 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:33183 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbbHCEcP (ORCPT ); Mon, 3 Aug 2015 00:32:15 -0400 Date: Mon, 3 Aug 2015 06:32:02 +0200 (CEST) From: Hans Ulli Kroll X-X-Sender: elektroman@T520.work To: Viresh Kumar cc: akpm@linux-foundation.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, "moderated list:BLACKFIN RTC DRIVER" , Alessandro Zummo , Alexandre Belloni , Hans Ulli Kroll , "moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" Subject: Re: [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2619 Lines: 76 Hi On Fri, 31 Jul 2015, Viresh Kumar wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. > > gemini driver was using likely() for a failure case while the rtc driver > is getting registered. That looks wrong and it should really be > unlikely. But because we are killing all the unlikely() flags, lets kill > that too. > > Signed-off-by: Viresh Kumar > --- > V1->V2: > - Removed the likely() part from gemini driver and the changelog wasn't > updated to match that. Fixed the changelog now. > > drivers/rtc/interface.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-gemini.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c > index 11b639067312..5836751b8203 100644 > --- a/drivers/rtc/interface.c > +++ b/drivers/rtc/interface.c > @@ -564,7 +564,7 @@ enum hrtimer_restart rtc_pie_update_irq(struct hrtimer *timer) > void rtc_update_irq(struct rtc_device *rtc, > unsigned long num, unsigned long events) > { > - if (unlikely(IS_ERR_OR_NULL(rtc))) > + if (IS_ERR_OR_NULL(rtc)) > return; > > pm_stay_awake(rtc->dev.parent); > diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c > index 3d44b11721ea..535a5f9338d0 100644 > --- a/drivers/rtc/rtc-bfin.c > +++ b/drivers/rtc/rtc-bfin.c > @@ -361,7 +361,7 @@ static int bfin_rtc_probe(struct platform_device *pdev) > /* Register our RTC with the RTC framework */ > rtc->rtc_dev = devm_rtc_device_register(dev, pdev->name, &bfin_rtc_ops, > THIS_MODULE); > - if (unlikely(IS_ERR(rtc->rtc_dev))) > + if (IS_ERR(rtc->rtc_dev)) > return PTR_ERR(rtc->rtc_dev); > > /* Grab the IRQ and init the hardware */ > diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c > index 35f4486738fc..2fed93e1114a 100644 > --- a/drivers/rtc/rtc-gemini.c > +++ b/drivers/rtc/rtc-gemini.c > @@ -148,7 +148,7 @@ static int gemini_rtc_probe(struct platform_device *pdev) > > rtc->rtc_dev = rtc_device_register(pdev->name, dev, > &gemini_rtc_ops, THIS_MODULE); > - if (likely(IS_ERR(rtc->rtc_dev))) > + if (IS_ERR(rtc->rtc_dev)) > return PTR_ERR(rtc->rtc_dev); > > return 0; > -- > 2.4.0 > > For the mach-gemini part Acked-by: Hans Ulli Kroll -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/