Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbbHCFHY (ORCPT ); Mon, 3 Aug 2015 01:07:24 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:55047 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbbHCFHW (ORCPT ); Mon, 3 Aug 2015 01:07:22 -0400 Message-ID: <55BEF6E4.2000905@ti.com> Date: Mon, 3 Aug 2015 10:36:44 +0530 From: Vignesh R User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Brian Norris CC: Mark Brown , David Woodhouse , Tony Lindgren , Russell King , Huang Shijie , , , , , , Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi References: <1438072876-16338-1-git-send-email-vigneshr@ti.com> <1438072876-16338-5-git-send-email-vigneshr@ti.com> <20150731212847.GH10676@google.com> In-Reply-To: <20150731212847.GH10676@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 46 On 08/01/2015 02:58 AM, Brian Norris wrote: > On Tue, Jul 28, 2015 at 02:11:15PM +0530, Vignesh R wrote: >> Add qspi memory mapped region entries for DRA7xx based SoCs. >> >> Signed-off-by: Vignesh R >> --- >> arch/arm/boot/dts/am4372.dtsi | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index ade28c790f4b..5317a0f24ab9 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -902,7 +902,9 @@ >> >> qspi: qspi@47900000 { >> compatible = "ti,am4372-qspi"; >> - reg = <0x47900000 0x100>; >> + reg = <0x47900000 0x100>, >> + <0x30000000 0x3ffffff>; > > Are you sure this region is 1 byte shy of 64MB in length? Same question > for patch 5. > Oops, my bad... Its 64MB in length, I entered offset of last byte instead of length. Will correct this in the actual patch. >> + reg-names = "qspi_base", "qspi_mmap"; >> #address-cells = <1>; >> #size-cells = <0>; >> ti,hwmods = "qspi"; >> -- >> 2.4.6 >> -- Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/