Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbbHCF3W (ORCPT ); Mon, 3 Aug 2015 01:29:22 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33416 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbbHCF3U (ORCPT ); Mon, 3 Aug 2015 01:29:20 -0400 Date: Mon, 3 Aug 2015 10:59:07 +0530 From: Sudip Mukherjee To: Shraddha Barke Cc: Dmitry Eremin , Andreas Dilger , Joe Perches , Paul Cassella , Greg Kroah-Hartman , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Revert "Staging : lustre: Struct file_operations should be const" Message-ID: <20150803052907.GA4207@sudip-pc> References: <1438513366-23462-1-git-send-email-shraddha.6596@gmail.com> <1438536862-7404-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438536862-7404-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 39 On Sun, Aug 02, 2015 at 11:04:22PM +0530, Shraddha Barke wrote: Your subject says 'Revert "Staging : lustre: Struct file_operations should be const"'. This patch reverts which commit? > Declare the file_operations structure ll_file_operations as const, as done > elsewhere in the kernel, as there are no modifications to its fields. > > Problem found using checkpatch. > > Signed-off-by: Shraddha Barke > --- > Changes in v2: > - Make the commit message more clearer. > > drivers/staging/lustre/lustre/llite/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c > index 369a722..dcd0c6d 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -3116,7 +3116,7 @@ int ll_inode_permission(struct inode *inode, int mask) > } > > /* -o localflock - only provides locally consistent flock locks */ > -const struct file_operations ll_file_operations = { > +struct file_operations ll_file_operations = { Your commit message says "Declare the file_operations structure ll_file_operations as const" but your patch is removing the const. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/