Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbbHCFpu (ORCPT ); Mon, 3 Aug 2015 01:45:50 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:56898 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbbHCFps (ORCPT ); Mon, 3 Aug 2015 01:45:48 -0400 Message-ID: <1438580745.16598.87.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 11/15] drivers: target: Drop unlikely before IS_ERR(_OR_NULL) From: "Nicholas A. Bellinger" To: Viresh Kumar Cc: akpm@linux-foundation.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Bart Van Assche , Christoph Hellwig , James Bottomley , "open list:TARGET SUBSYSTEM" , martin.petersen@oracle.com, "open list:TARGET SUBSYSTEM" Date: Sun, 02 Aug 2015 22:45:45 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 32 On Fri, 2015-07-31 at 14:08 +0530, Viresh Kumar wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. > > Signed-off-by: Viresh Kumar > --- > drivers/target/tcm_fc/tfc_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c > index 68031723e5be..aa3caca8bace 100644 > --- a/drivers/target/tcm_fc/tfc_cmd.c > +++ b/drivers/target/tcm_fc/tfc_cmd.c > @@ -255,7 +255,7 @@ static void ft_recv_seq(struct fc_seq *sp, struct fc_frame *fp, void *arg) > struct ft_cmd *cmd = arg; > struct fc_frame_header *fh; > > - if (unlikely(IS_ERR(fp))) { > + if (IS_ERR(fp)) { > /* XXX need to find cmd if queued */ > cmd->seq = NULL; > cmd->aborted = true; Looks fine. Applied to target-pending/for-next. Thanks Viresh! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/