Date: Mon, 03 Aug 2015 05:50:17 +0000 (GMT)
From: MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before
 IS_ERR(_OR_NULL)
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= <kyungmin.park@samsung.com>,
        "open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@vger.kernel.org>
Reply-to: myungjoo.ham@samsung.com
MIME-version: 1.0
Msgkey: 20150803054854463@myungjoo.ham
Content-type: text/plain; charset=utf-8
MIME-version: 1.0
Message-id: <1197027641.344961438581016329.JavaMail.weblogic@epmlwas06d>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1041
Lines: 38

> On 03-08-15, 05:10, MyungJoo Ham wrote:
> > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > > is no need to do that again from its callers. Drop it.
> > > 
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > @ from include/linux/err.h
> > #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> > ...
> > static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> > {
> > 	return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> > }
> > 
> > "!ptr" appears not covered with IS_ERR_OR_NULL.
> > (only the IS_ERR part seems covered)
> 
> Right, the first patch of the series has fixed that.
> 
> http://permalink.gmane.org/gmane.linux.kernel/2009151

Ah.. ok, then,


Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>


please let me know when the series is ready to go.


Cheers,
MyungJoo

> 
> -- 
> viresh
> 
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?