Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbbHCGQX (ORCPT ); Mon, 3 Aug 2015 02:16:23 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46949 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbHCGQU (ORCPT ); Mon, 3 Aug 2015 02:16:20 -0400 Date: Mon, 3 Aug 2015 09:15:56 +0300 From: Dan Carpenter To: "Wang, Biao" Cc: "gregkh@linuxfoundation.org" , "arve@android.com" , "riandrews@android.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Zhang, Di" , "Li, Fei" , "joe@perches.com" Subject: Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue Message-ID: <20150803061556.GS5096@mwanda> References: <09CB0B4607EB8F4DB7E0BE3B06BFBD051DA2E849@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09CB0B4607EB8F4DB7E0BE3B06BFBD051DA2E849@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 27 On Mon, Aug 03, 2015 at 05:53:22AM +0000, Wang, Biao wrote: > Consider the following case: > Task A trigger lmk with a lock held, while task B try to > get this lock, but unfortunately B is the very culprit task lmk select to > kill. Then B will never be killed, and A will forever select B to kill. > Such dead lock will trigger softlock up issue. > > This patch try to pick the next task to break this loop. > > Signed-off-by: Wang Biao > Reviewed-by: Zhang Di > Reviewed-by: Dan Carpenter I don't really feel comfortable saying I reviewed this code. I just commented on a few process issues. I don't know the subsystem well enough to give it a seal of approval. > Reviewed-by: Joe Perches regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/