Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbbHCG7M (ORCPT ); Mon, 3 Aug 2015 02:59:12 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:45199 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbHCG7K (ORCPT ); Mon, 3 Aug 2015 02:59:10 -0400 Date: Mon, 3 Aug 2015 08:59:15 +0200 From: Ludovic Desroches To: Josh Wu CC: Ludovic Desroches , , , , , , Subject: Re: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux Message-ID: <20150803065915.GF4055@odux.rfo.atmel.com> Mail-Followup-To: Josh Wu , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, nicolas.ferre@atmel.com, linus.walleij@linaro.org References: <1438355290-28255-1-git-send-email-ludovic.desroches@atmel.com> <1438355290-28255-3-git-send-email-ludovic.desroches@atmel.com> <55BF0CD2.5030204@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55BF0CD2.5030204@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 39 Hi Josh, On Mon, Aug 03, 2015 at 02:40:18PM +0800, Josh Wu wrote: > Hi, Ludovic > > On 7/31/2015 11:08 PM, Ludovic Desroches wrote: > >Signed-off-by: Ludovic Desroches > >--- > > arch/arm/boot/dts/sama5d2-pinfunc.h | 760 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 760 insertions(+) > > create mode 100644 arch/arm/boot/dts/sama5d2-pinfunc.h > > > >diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h > >new file mode 100644 > >index 0000000..046d1d5 > >--- /dev/null > >+++ b/arch/arm/boot/dts/sama5d2-pinfunc.h > > > > [snip...] > > >+#define PIN_PB24__FLEXCOM3_IO3 PINMUX_PIN(PIN_PB24, 5, 3) > >+#define PIN_PB24__ISI_D10 PINMUX_PIN(PIN_PB24, 6, 3) > > As sama5d2 use ISC, so It's better to run s/ISI_/ISC_/ in this file, which > is consistent with the datasheet. > Ok, the one I used was a bit older and was still with ISI instead of ISC. I'll update this file. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/