Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbbHCHSs (ORCPT ); Mon, 3 Aug 2015 03:18:48 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36840 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbbHCHSr (ORCPT ); Mon, 3 Aug 2015 03:18:47 -0400 Date: Mon, 3 Aug 2015 12:48:38 +0530 From: Sudip Mukherjee To: Shraddha Barke Cc: Oleg Drokin , Al Viro , Julia Lawall , aybuke ozdemir , Andreas Dilger , "John L. Hammond" , Frank Zago , Greg Kroah-Hartman , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging : lustre: Struct file_operations should be const Message-ID: <20150803071838.GB26465@sudip-pc> References: <1438580826-1288-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438580826-1288-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2430 Lines: 45 On Mon, Aug 03, 2015 at 11:17:06AM +0530, Shraddha Barke wrote: > Declare the file_operations structure ll_file_operations as const, as done > elsewhere in the kernel, as there are no modifications to its fields. > > Problem found using checkpatch: > > WARNING: struct file_operations should normally be const > > Signed-off-by: Shraddha Barke > --- You have not even build tested your patch before sending. :( drivers/staging/lustre/lustre/llite/file.c:3119:30: error: conflicting type qualifiers for ‘ll_file_operations’ const struct file_operations ll_file_operations = { ^ In file included from drivers/staging/lustre/lustre/llite/file.c:48:0: drivers/staging/lustre/lustre/llite/llite_internal.h:710:31: note: previous declaration of ‘ll_file_operations’ was here extern struct file_operations ll_file_operations; ^ drivers/staging/lustre/lustre/llite/file.c:3132:30: error: conflicting type qualifiers for ‘ll_file_operations_flock’ const struct file_operations ll_file_operations_flock = { ^ In file included from drivers/staging/lustre/lustre/llite/file.c:48:0: drivers/staging/lustre/lustre/llite/llite_internal.h:711:31: note: previous declaration of ‘ll_file_operations_flock’ was here extern struct file_operations ll_file_operations_flock; ^ drivers/staging/lustre/lustre/llite/file.c:3148:30: error: conflicting type qualifiers for ‘ll_file_operations_noflock’ const struct file_operations ll_file_operations_noflock = { ^ In file included from drivers/staging/lustre/lustre/llite/file.c:48:0: drivers/staging/lustre/lustre/llite/llite_internal.h:712:31: note: previous declaration of ‘ll_file_operations_noflock’ was here extern struct file_operations ll_file_operations_noflock; ^ make[3]: *** [drivers/staging/lustre/lustre/llite/file.o] Error 1 make[2]: *** [drivers/staging/lustre/lustre/llite] Error 2 make[1]: *** [drivers/staging/lustre/lustre] Error 2 make: *** [_module_drivers/staging/lustre] Error 2 regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/