Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752311AbbHCHZr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 03:25:47 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:33339 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751770AbbHCHZp convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 03:25:45 -0400
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>
From: yalin wang <yalin.wang2010@gmail.com>
In-Reply-To: <1438547113.29569.5.camel@perches.com>
Date: Mon, 3 Aug 2015 15:25:38 +0800
Cc: Don Brace <don.brace@pmcs.com>, linux-kernel@vger.kernel.org,
        iss_storagedev@hp.com, storagedev@pmcs.com,
        linux-scsi <linux-scsi@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <9547AF94-2168-4987-AD89-B7F111084CC2@gmail.com>
References: <1438547113.29569.5.camel@perches.com>
To: Joe Perches <joe@perches.com>
X-Mailer: Apple Mail (2.2098)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2503
Lines: 59


> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote:
> 
> Correct misuse of 0x%d in logging messages.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/block/DAC960.c | 4 ++--
> drivers/block/cciss.c  | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index 811e11c..d9b32f2 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>        case DAC960_PD_Controller:
>          if (!request_region(Controller->IO_Address, 0x80,
>                              Controller->FullModelName)) {
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                             Controller, Controller->IO_Address);
>                goto Failure;
>          }
> @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
>        case DAC960_P_Controller:
>          if (!request_region(Controller->IO_Address, 0x80,
>                              Controller->FullModelName)){
> -               DAC960_Error("IO port 0x%d busy for Controller at\n",
> +               DAC960_Error("IO port 0x%x busy for Controller at\n",
>                             Controller, Controller->IO_Address);
>                goto Failure;
>          }
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 0422c47..2758982 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h)
>               readl(&(tb->HostWrite.CoalIntDelay)));
>        dev_dbg(&h->pdev->dev, "   Coalesce Interrupt Count = 0x%x\n",
>               readl(&(tb->HostWrite.CoalIntCount)));
> -       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%d\n",
> +       dev_dbg(&h->pdev->dev, "   Max outstanding commands = 0x%x\n",
>               readl(&(tb->CmdsOutMax)));
>        dev_dbg(&h->pdev->dev, "   Bus Types = 0x%x\n",
>                readl(&(tb->BusTypes)));
> ?
why not use like this : dev_dbg(&h->pdev->dev, "   Max outstanding commands = %#x\n?  ? 
%#x will add 0x prefix automatically .

Thanks



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/